Fix #422 invalid fields in MultiUsersSelectAction #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
bug
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
======================================
Coverage 81.5% 81.5%
======================================
Files 7 7
Lines 530 530
Branches 152 152
======================================
Hits 432 432
Misses 70 70
Partials 28 28Continue to review full report at Codecov.
|
stevengill
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #422 which is my bad in #344. This is a blocker for TypeScript users and is causing bad developer experiences for Visual Studio Code users.
Requirements (place an
xin each[ ])